Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add endpoints for recording management (#2901) #2988

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Feb 4, 2024

No description provided.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (5e27304) 51.98% compared to head (4b907b7) 53.66%.

Files Patch % Lines
internal/api/api.go 63.26% 28 Missing and 8 partials ⚠️
internal/api/record.go 63.82% 32 Missing and 2 partials ⚠️
internal/playback/server.go 50.00% 3 Missing and 2 partials ⚠️
internal/playback/segment.go 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2988      +/-   ##
==========================================
+ Coverage   51.98%   53.66%   +1.68%     
==========================================
  Files         131      132       +1     
  Lines       12881    13066     +185     
==========================================
+ Hits         6696     7012     +316     
+ Misses       5655     5486     -169     
- Partials      530      568      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 0332ba5 into main Feb 4, 2024
8 checks passed
@aler9 aler9 deleted the feature/api-recordings branch February 4, 2024 22:51
Copy link
Contributor

github-actions bot commented Feb 4, 2024

This issue is mentioned in release v1.5.1 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant