Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp: support publishing G711 and LPCM tracks (#2857) #2884

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jan 7, 2024

Fixes #2857

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (bc7804c) 52.58% compared to head (c352080) 53.17%.

Files Patch % Lines
internal/protocols/rtmp/reader.go 33.80% 40 Missing and 7 partials ⚠️
internal/protocols/rtmp/writer.go 25.92% 20 Missing ⚠️
internal/formatprocessor/ac3.go 0.00% 2 Missing ⚠️
internal/formatprocessor/av1.go 0.00% 2 Missing ⚠️
internal/formatprocessor/h264.go 50.00% 2 Missing ⚠️
internal/formatprocessor/h265.go 50.00% 2 Missing ⚠️
internal/formatprocessor/mjpeg.go 0.00% 2 Missing ⚠️
internal/formatprocessor/mpeg1_audio.go 0.00% 2 Missing ⚠️
internal/formatprocessor/mpeg1_video.go 0.00% 2 Missing ⚠️
internal/formatprocessor/mpeg4_audio.go 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2884      +/-   ##
==========================================
+ Coverage   52.58%   53.17%   +0.59%     
==========================================
  Files         124      124              
  Lines       11367    11448      +81     
==========================================
+ Hits         5977     6088     +111     
+ Misses       4938     4906      -32     
- Partials      452      454       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 27975d8 into main Jan 7, 2024
7 of 8 checks passed
@aler9 aler9 deleted the feature/rtmp-lpcm branch January 7, 2024 16:02
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue is mentioned in release v1.4.2 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support G711 in RTMP
1 participant