Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow using 'fallback' with static sources (#2606) #2706

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 16, 2023

Fixes #2606

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3277765) 59.43% compared to head (1d716d9) 59.80%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/conf/path.go 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2706      +/-   ##
==========================================
+ Coverage   59.43%   59.80%   +0.36%     
==========================================
  Files         144      144              
  Lines       15315    15312       -3     
==========================================
+ Hits         9103     9157      +54     
+ Misses       5571     5512      -59     
- Partials      641      643       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit c3d9be3 into main Nov 16, 2023
7 of 8 checks passed
@aler9 aler9 deleted the bug/fallback branch November 16, 2023 22:37
Copy link
Contributor

This issue is mentioned in release v1.3.1 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Path fallback no longer works since commit eb97502
1 participant