Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query, username and password to session list #2689

Conversation

krusadellc
Copy link

Adds URL query and basic username and password to RTSP Sessions API

@jonra1993
Copy link

I think this could be related to this bug #2701

@krusadellc
Copy link
Author

@jonra1993 it's not related to that bug.
This PR just adds query params and username/password to the RTSP List Sessions API

@krusadellc
Copy link
Author

@aler9 can you please take a look?

@aler9
Copy link
Member

aler9 commented Nov 16, 2023

Hello, username and password must not be saved or displayed publicly, even to administrators, since it constitutes a security issue. Adding the query is a good idea. Therefore:

  • remove username and password from APIRTSPSession
  • add query to APIRTMPConn, APIWebRTCSession too

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a1e155) 59.41% compared to head (88489af) 59.43%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2689      +/-   ##
==========================================
+ Coverage   59.41%   59.43%   +0.01%     
==========================================
  Files         144      144              
  Lines       15315    15322       +7     
==========================================
+ Hits         9100     9106       +6     
- Misses       5574     5575       +1     
  Partials      641      641              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9
Copy link
Member

aler9 commented Dec 26, 2023

Superseded by #2844

Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue is mentioned in release v1.4.2 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants