Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: prevent pion/webrtc from writing log lines #2681

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 12, 2023

No description provided.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #2681 (c1f25b4) into main (5ae35af) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head c1f25b4 differs from pull request most recent head 7a2e56e. Consider uploading reports for the commit 7a2e56e to get more accurate results

@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
+ Coverage   59.53%   59.55%   +0.02%     
==========================================
  Files         144      144              
  Lines       15289    15291       +2     
==========================================
+ Hits         9102     9107       +5     
+ Misses       5548     5545       -3     
  Partials      639      639              
Files Coverage Δ
internal/core/webrtc_manager.go 63.63% <0.00%> (-0.41%) ⬇️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aler9 aler9 merged commit 83a3086 into main Nov 12, 2023
6 checks passed
@aler9 aler9 deleted the bug/webrtc-log branch November 12, 2023 12:46
Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant