Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record: fix deleting segments in case of relative paths (#2526) #2673

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 10, 2023

Fixes #2526

@aler9 aler9 mentioned this pull request Nov 10, 2023
13 tasks
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2673 (15a8ed3) into main (fb585b5) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2673      +/-   ##
==========================================
+ Coverage   59.49%   59.50%   +0.01%     
==========================================
  Files         144      144              
  Lines       15267    15271       +4     
==========================================
+ Hits         9083     9087       +4     
  Misses       5545     5545              
  Partials      639      639              
Files Coverage Δ
internal/record/cleaner.go 87.09% <100.00%> (+0.57%) ⬆️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aler9 aler9 merged commit d51baa0 into main Nov 10, 2023
8 checks passed
@aler9 aler9 deleted the bug/cleaner-abs branch November 10, 2023 15:03
Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recording does not delete files
1 participant