Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setting 'recordDeleteAfter' to zero (#2670) #2671

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 10, 2023

Fixes #2670

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2671 (57679c8) into main (fb585b5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
- Coverage   59.49%   59.48%   -0.01%     
==========================================
  Files         144      144              
  Lines       15267    15267              
==========================================
- Hits         9083     9082       -1     
- Misses       5545     5546       +1     
  Partials      639      639              
Files Coverage Δ
internal/core/core.go 85.73% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aler9 aler9 merged commit ef19552 into main Nov 10, 2023
7 of 8 checks passed
@aler9 aler9 deleted the bug/record-delete-after-zero branch November 10, 2023 12:51
@aler9 aler9 mentioned this pull request Nov 10, 2023
13 tasks
Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow server wide disabling of recording Cleaner
1 participant