Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: allow using special characters in ICE server credentials (#1953) #2000

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 29, 2023

Fixes #1953

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2000 (e2dc258) into main (059ca76) will increase coverage by 0.01%.
The diff coverage is 63.04%.

❗ Current head e2dc258 differs from pull request most recent head 660a57c. Consider uploading reports for the commit 660a57c to get more accurate results

@@            Coverage Diff             @@
##             main    #2000      +/-   ##
==========================================
+ Coverage   62.19%   62.20%   +0.01%     
==========================================
  Files         108      108              
  Lines       11332    11357      +25     
==========================================
+ Hits         7048     7065      +17     
- Misses       3782     3787       +5     
- Partials      502      505       +3     
Impacted Files Coverage Δ
internal/conf/auth_method.go 27.27% <ø> (ø)
internal/conf/hls_variant.go 0.00% <ø> (ø)
internal/conf/ips_or_cidrs.go 0.00% <ø> (ø)
internal/conf/log_destination.go 0.00% <ø> (ø)
internal/conf/log_level.go 17.64% <ø> (ø)
internal/conf/rtsp_range_type.go 0.00% <ø> (ø)
internal/conf/source_protocol.go 0.00% <ø> (ø)
internal/conf/string_duration.go 37.50% <ø> (ø)
internal/conf/string_size.go 0.00% <ø> (ø)
internal/core/webrtc_manager.go 66.92% <46.15%> (+2.89%) ⬆️
... and 5 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 1a748bb into main Jun 30, 2023
@aler9 aler9 deleted the bug/webrtc-ice-servers branch June 30, 2023 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TURN username and password may not contain :.
1 participant