Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: add option to disable audio effects (#1908) #1989

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 26, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #1989 (972cd58) into main (fb1f8ff) will increase coverage by 0.36%.
The diff coverage is 14.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1989      +/-   ##
==========================================
+ Coverage   61.12%   61.49%   +0.36%     
==========================================
  Files         108      108              
  Lines       11474    11400      -74     
==========================================
- Hits         7014     7010       -4     
+ Misses       3944     3869      -75     
- Partials      516      521       +5     
Impacted Files Coverage Δ
internal/core/webrtc_manager.go 62.70% <ø> (ø)
internal/core/webrtc_session.go 62.85% <5.66%> (-4.05%) ⬇️
internal/core/webrtc_pc.go 66.42% <25.92%> (+27.84%) ⬆️
internal/core/webrtc_http_server.go 64.17% <100.00%> (+0.28%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 force-pushed the feature/webrtc-audio-effects branch from fea7f85 to 972cd58 Compare June 26, 2023 09:45
@aler9 aler9 force-pushed the feature/webrtc-audio-effects branch from 972cd58 to 8a24d2b Compare June 27, 2023 20:16
@aler9 aler9 merged commit 79ee4e0 into main Jun 27, 2023
@aler9 aler9 deleted the feature/webrtc-audio-effects branch June 27, 2023 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants