Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reading MP4A-LATM-encoded AAC with RTMP and HLS (#1694) #1898

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 1, 2023

Fixes #1694

@codecov-commenter
Copy link

Codecov Report

Merging #1898 (2ae79e5) into main (91ec498) will decrease coverage by 1.26%.
The diff coverage is 20.11%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
- Coverage   62.15%   60.89%   -1.26%     
==========================================
  Files         107      108       +1     
  Lines       11243    11451     +208     
==========================================
- Hits         6988     6973      -15     
- Misses       3743     3959     +216     
- Partials      512      519       +7     
Impacted Files Coverage Δ
internal/core/hls_source.go 55.78% <0.00%> (ø)
internal/core/udp_source.go 0.00% <0.00%> (ø)
internal/formatprocessor/mpeg2audio.go 0.00% <0.00%> (ø)
internal/formatprocessor/mpeg4audio_generic.go 0.00% <0.00%> (ø)
internal/formatprocessor/mpeg4audio_latm.go 0.00% <0.00%> (ø)
internal/formatprocessor/opus.go 0.00% <0.00%> (ø)
internal/formatprocessor/processor.go 45.45% <0.00%> (-4.55%) ⬇️
internal/formatprocessor/vp8.go 0.00% <0.00%> (ø)
internal/formatprocessor/vp9.go 0.00% <0.00%> (ø)
internal/core/rtmp_conn.go 52.06% <16.36%> (-3.14%) ⬇️
... and 6 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 681a003 into main Jun 1, 2023
@aler9 aler9 deleted the feature/latm branch June 1, 2023 22:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MP4A-LATM format for audio in HLS and RTMP
2 participants