fix: metrics listener address sanitization #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 3475762 from PR bluenviron#1678 the restrictNetwork function was called twice for the metrics listening address only, which leads to 0.0.0.0 listeners not working properly for the metrics server.
|
@aler9 please note that I haven't tested this out, but it makes intuitive sense based on the other changes from that commit. Seems like it was just a typo before. |
|
merged, thanks |
|
added in v0.23.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 3475762 from PR #1678 the restrictNetwork function was called twice for the metrics listening address only, which leads to 0.0.0.0 listeners not working properly for the metrics server.