Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support publishing H265 and AV1 tracks with Enhanced RTMP (#1393) (#1446) (#1621) #1756

Merged
merged 2 commits into from
May 4, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 2, 2023

Fixes #1446

Fixes #1621

TODO:

  • support publishing H265 with enhanced RTMP
  • support publishing AV1 with enhanced RTMP

@aler9 aler9 force-pushed the feature-rtmp-enh branch 3 times, most recently from 6448fee to 11f3b37 Compare May 4, 2023 10:37
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Merging #1756 (a76a15b) into main (225220d) will decrease coverage by 0.96%.
The diff coverage is 52.38%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1756      +/-   ##
==========================================
- Coverage   63.11%   62.15%   -0.96%     
==========================================
  Files          91      101      +10     
  Lines       10087    10365     +278     
==========================================
+ Hits         6366     6442      +76     
- Misses       3270     3468     +198     
- Partials      451      455       +4     
Impacted Files Coverage Δ
internal/formatprocessor/av1.go 0.00% <0.00%> (ø)
internal/formatprocessor/h264.go 77.67% <0.00%> (ø)
internal/formatprocessor/h265.go 76.29% <0.00%> (ø)
internal/formatprocessor/processor.go 40.00% <0.00%> (-4.45%) ⬇️
internal/rtmp/message/extended_metadata.go 0.00% <0.00%> (ø)
...al/rtmp/message/extended_mpeg2ts_sequence_start.go 0.00% <0.00%> (ø)
internal/rtmp/message/extended_sequence_end.go 0.00% <0.00%> (ø)
internal/rtmp/message/extended_sequence_start.go 0.00% <0.00%> (ø)
internal/rtmp/message/set_peer_bandwidth.go 0.00% <0.00%> (ø)
internal/rtmp/message/set_window_ack_size.go 0.00% <0.00%> (ø)
... and 29 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 force-pushed the feature-rtmp-enh branch 8 times, most recently from a5f3013 to f18a0fc Compare May 4, 2023 18:08
@aler9 aler9 force-pushed the feature-rtmp-enh branch 3 times, most recently from 0e830e7 to b935843 Compare May 4, 2023 18:23
@aler9 aler9 merged commit e8124e2 into main May 4, 2023
@aler9 aler9 deleted the feature-rtmp-enh branch May 4, 2023 18:37
@aler9 aler9 mentioned this pull request May 14, 2023
12 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Enhanced RTMP Support publishing with OBS, RTMP and AV1
2 participants