Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reading H265 tracks with HLS #1342

Merged
merged 2 commits into from
Dec 29, 2022
Merged

support reading H265 tracks with HLS #1342

merged 2 commits into from
Dec 29, 2022

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 29, 2022

Fixes #469

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #1342 (2d10744) into main (37baa33) will decrease coverage by 1.16%.
The diff coverage is 39.58%.

@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
- Coverage   62.38%   61.22%   -1.17%     
==========================================
  Files         113      113              
  Lines       12025    12291     +266     
==========================================
+ Hits         7502     7525      +23     
- Misses       3928     4168     +240     
- Partials      595      598       +3     
Impacted Files Coverage Δ
internal/core/formatprocessor_h265.go 26.22% <0.00%> (-10.42%) ⬇️
internal/core/rpicamera_source.go 0.00% <0.00%> (ø)
internal/core/webrtc_conn.go 0.00% <0.00%> (ø)
internal/hls/mpegts/writer.go 88.97% <ø> (ø)
internal/hls/muxer_variant_fmp4_part.go 93.33% <ø> (ø)
internal/hls/muxer_variant_fmp4_playlist.go 34.34% <ø> (ø)
internal/hls/muxer_variant_fmp4_segment.go 69.02% <ø> (ø)
internal/hls/muxer_variant_mpegts_segmenter.go 88.72% <0.00%> (ø)
internal/hls/fmp4/init_track.go 52.06% <27.13%> (-15.73%) ⬇️
internal/hls/muxer_variant_fmp4.go 73.78% <38.46%> (-22.37%) ⬇️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 5de600f into main Dec 29, 2022
@aler9 aler9 deleted the hls-h265 branch December 29, 2022 19:46
@thanhlnbka
Copy link

thanhlnbka commented Dec 30, 2022

I tried pushlish rtsp format h265 to the server and read with hls low latency but it didn't work
I got an error like this, do you know why ?
I use google chorme version 108.0.5359.124 to open https://localhost:8888/mystream
image

@aler9
Copy link
Member Author

aler9 commented Dec 30, 2022

@thanhlnbka can you provide a sample video that triggers the error? Thanks

@thanhlnbka
Copy link

thanhlnbka commented Dec 30, 2022

Sorry, I can't give you a sample video because I use h265 rtsp stream to pushlish to the server.
I use ffmpeg to push : ffmpeg -i rtsp:// -c copy -f rtsp rtsp://localhost:8554/mystream and open vlc with stream rtsp://localhost:8554/mystream as well

@aler9
Copy link
Member Author

aler9 commented Dec 30, 2022

You can generate a sample by running

ffmpeg -i rtsp://yourcamera -t 00:30:00 -c copy -f mpegts mysample.ts

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HLS support for h265 rtsp.
3 participants