-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(webrtc) added support for ice mux tcp and nat1to1ips #1323
Conversation
please allow to use this server with this kind of features or it will be hard or impossible to use the webrtc streams with containerized environments. This features enable useful functionalities that are right now embedded in software like wowza. |
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
- Coverage 62.48% 62.23% -0.26%
==========================================
Files 113 113
Lines 12020 12074 +54
==========================================
+ Hits 7511 7514 +3
- Misses 3915 3962 +47
- Partials 594 598 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I applied codecov's suggestions, now it should be fine |
Hello,
thanks |
@aler9 I should have done everything |
This has been merged with some changes, thanks for providing the code. I'm interested too it in the possibility of running the server inside a container without Furthermore, i'll also dig into |
Added in v0.21.1 |
With this pull request introduce the following features:
Configuration will have some new parameters:
Using webrtc ice tcp mux allows your software to work properly on network infrastructures (server side) where you have more stringent limitations, in our case we needed it to work through a single tcp port, for example.
We need NAT1To1IPs because the software runs inside a container where it is exposed to the internet via a virtual network interface, without specifying NAT1To1IPs to webrtc the candidate will get an invalid ip.