Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api, metrics: add number of bytes received and sent from/to all entities #1235

Merged
merged 11 commits into from
Nov 11, 2022

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 9, 2022

Fixes #734

TODO:

  • API: number of bytes received/sent from/to RTSP connections
  • API: number of bytes received/sent from/to RTSP sessions
  • API: number of bytes received/sent from/to RTMP connections
  • API: number of bytes sent to HLS connections
  • API: number of bytes received from paths
  • metrics of all the above

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #1235 (9d49780) into main (71ef9b4) will decrease coverage by 0.07%.
The diff coverage is 83.63%.

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
- Coverage   67.16%   67.09%   -0.08%     
==========================================
  Files         107      107              
  Lines        8941     8934       -7     
==========================================
- Hits         6005     5994      -11     
- Misses       2367     2370       +3     
- Partials      569      570       +1     
Impacted Files Coverage Δ
internal/core/rtmp_server.go 86.39% <ø> (ø)
internal/core/hls_muxer.go 58.88% <57.89%> (+0.12%) ⬆️
internal/core/metrics.go 87.87% <70.96%> (+3.50%) ⬆️
internal/core/rtsp_session.go 65.23% <92.85%> (ø)
internal/core/hls_server.go 75.74% <100.00%> (ø)
internal/core/path.go 73.09% <100.00%> (+0.24%) ⬆️
internal/core/rtsp_server.go 89.15% <100.00%> (+0.10%) ⬆️
internal/core/stream.go 92.85% <100.00%> (+0.26%) ⬆️
internal/core/streamtrack_h264.go 73.64% <100.00%> (ø)
internal/core/streamtrack_mpeg4audio.go 27.27% <100.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 changed the title api, metrics: add number of bytes received and written from/to all entities api, metrics: add number of bytes received and sent from/to all entities Nov 10, 2022
@aler9 aler9 force-pushed the bytecount branch 3 times, most recently from a6c664f to e18a8f1 Compare November 11, 2022 09:25
@aler9 aler9 merged commit 8bee4af into main Nov 11, 2022
@aler9 aler9 deleted the bytecount branch November 11, 2022 10:59
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bandwidth metrics per source and per session
2 participants