Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode streams once and only when needed #1218

Merged
merged 7 commits into from
Nov 2, 2022
Merged

Decode streams once and only when needed #1218

merged 7 commits into from
Nov 2, 2022

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 2, 2022

TODO:

  • PTS synchronization
  • restore logging of decode errors
  • remove H264 re-encoding from gortsplib and move it here
  • remove H264 decoding from gortsplib and move it here
  • oversized tests

@aler9 aler9 force-pushed the ondemand-data branch 2 times, most recently from bbe6494 to b56ed0b Compare November 2, 2022 08:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #1218 (1734426) into main (a4363df) will decrease coverage by 0.11%.
The diff coverage is 41.25%.

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
- Coverage   68.13%   68.01%   -0.12%     
==========================================
  Files         106      107       +1     
  Lines        8816     8874      +58     
==========================================
+ Hits         6007     6036      +29     
- Misses       2247     2270      +23     
- Partials      562      568       +6     
Impacted Files Coverage Δ
internal/core/rpicamera_source.go 0.00% <0.00%> (ø)
internal/core/streamtrack_generic.go 0.00% <0.00%> (ø)
internal/hls/muxer_variant_fmp4_segmenter.go 73.84% <0.00%> (-0.77%) ⬇️
internal/core/streamtrack_mpeg4audio.go 33.33% <4.34%> (-11.12%) ⬇️
internal/core/hls_source.go 72.46% <20.00%> (-3.30%) ⬇️
internal/core/rtmp_source.go 71.92% <20.00%> (+0.75%) ⬆️
internal/core/data.go 33.33% <33.33%> (ø)
internal/core/rtsp_session.go 65.53% <35.29%> (-4.38%) ⬇️
internal/core/rtmp_conn.go 65.12% <37.77%> (-1.55%) ⬇️
internal/core/rtsp_source.go 71.55% <43.75%> (-4.45%) ⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 force-pushed the ondemand-data branch 2 times, most recently from 4c8b24c to e9896b9 Compare November 2, 2022 09:30
@aler9 aler9 merged commit 0943b26 into main Nov 2, 2022
@aler9 aler9 deleted the ondemand-data branch November 2, 2022 19:52
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants