Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opus channel count is wrongly set in MPEG-TS and fMP4 based protocols #3355

Closed
1 of 13 tasks
aler9 opened this issue May 14, 2024 · 5 comments
Closed
1 of 13 tasks

Opus channel count is wrongly set in MPEG-TS and fMP4 based protocols #3355

aler9 opened this issue May 14, 2024 · 5 comments

Comments

@aler9
Copy link
Member

aler9 commented May 14, 2024

Which version are you using?

v1.8.1

Which operating system are you using?

  • Linux amd64 standard
  • Linux amd64 Docker
  • Linux arm64 standard
  • Linux arm64 Docker
  • Linux arm7 standard
  • Linux arm7 Docker
  • Linux arm6 standard
  • Linux arm6 Docker
  • Windows amd64 standard
  • Windows amd64 Docker (WSL backend)
  • macOS amd64 standard
  • macOS amd64 Docker
  • Other (please describe)

Describe the issue

Discussed in #3353

Opus streams with a channel count > 3 cannot be streamed correctly, since the channel count is always set to either 1 or 2 due to a RTSP limitation.

Describe how to replicate the issue

N/A

Did you attach the server logs?

no

Did you attach a network dump?

no

@aler9
Copy link
Member Author

aler9 commented May 17, 2024

additional infos: multichannel Opus streams can be streamed with RTSP (and probably Chrome WebRTC) through a custom RTP format created by Google and documented here:

https://webrtc-review.googlesource.com/c/src/+/129768
https://gstreamer.freedesktop.org/documentation/rtp/rtpopuspay.html?gi-language=c
https://issues.webrtc.org/issues/42233792

@aler9
Copy link
Member Author

aler9 commented May 18, 2024

TODO

aler9 added a commit to bluenviron/gortsplib that referenced this issue May 18, 2024
aler9 added a commit to bluenviron/gortsplib that referenced this issue May 18, 2024
aler9 added a commit that referenced this issue May 18, 2024
aler9 added a commit that referenced this issue May 18, 2024
aler9 added a commit to bluenviron/gortsplib that referenced this issue May 19, 2024
aler9 added a commit that referenced this issue May 19, 2024
@aler9
Copy link
Member Author

aler9 commented May 19, 2024

WebRTC issue moved in #3371

@aler9 aler9 closed this as completed May 19, 2024
Copy link
Contributor

This issue is mentioned in release v1.8.2 🚀
Check out the entire changelog by clicking here

Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant