Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more modern authentication mechanisms #1992

Closed
statmatt opened this issue Jun 26, 2023 · 4 comments · Fixed by #3081
Closed

Support more modern authentication mechanisms #1992

statmatt opened this issue Jun 26, 2023 · 4 comments · Fixed by #3081
Labels

Comments

@statmatt
Copy link

Describe the feature

The current simple user:pass@host scheme used for basic auth is blocked by most browsers due to SRI. Thus, the instructions to embed links from the mediamtx server with this authentication is blocked. The documentation does not provide any real alternatives (for example, externalAuthentication, would it work, or would that also block the ingestion from RTSP proxy source?)

@saket424
Copy link

external auth with hmac token passed in as a query parameter works well for rtsp, rtmp, whep. i am using nodered as my external verifier

@aler9
Copy link
Member

aler9 commented Jul 13, 2023

Hello, I think we're dealing with two different issues here:

  • regarding the ability to use URLs with embedded credentials (i.e. http://user:pass@host), this feature is not mandatory to use, is not recommended in any way by the README, and the reason why it is blocked by browsers is unrelated from the underlying authentication mechanism: it is blocked to avoid users from sharing their credentials by mistake, whichever credentials they are using (and they can be JWT, hmac, sha, etc). Moving credentials into query parameters would incur in the security issue i just mentioned. Therefore, credentials must be left when they are, for the moment.

  • regarding support for different authentication methods, i think we can add native support for JWTs and LDAP, although both methods can be already implemented by using the external authentication specification.

@aler9 aler9 added enhancement New feature or request general labels Jul 19, 2023
@aler9 aler9 changed the title More modern authentication mechanism - embedded url user:pass is blocked by most browsers as a subresource More modern authentication mechanisms Aug 16, 2023
@aler9 aler9 changed the title More modern authentication mechanisms Support more modern authentication mechanisms Aug 28, 2023
aler9 added a commit that referenced this issue Mar 4, 2024
This is a new authentication system that covers all the features exposed by the server, including playback, API, metrics and PPROF, improves internal authentication by adding permissions, improves HTTP-based authentication by adding the ability to exclude certain actions from being authenticated, adds an additional method (JWT-based authentication).
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue is mentioned in release v1.6.0 🚀
Check out the entire changelog by clicking here

Copy link
Contributor

github-actions bot commented Sep 6, 2024

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants