Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.23.1 WebRTC-WHIP] It cannot work in the LAN. using chrome of pc or Android phone to push stream to the server. #1836

Closed
12 tasks
iesv opened this issue May 19, 2023 · 10 comments · Fixed by #2080
Labels
bug Something isn't working webrtc

Comments

@iesv
Copy link

iesv commented May 19, 2023

Which version are you using?

v0.23.1

Which operating system are you using?

  • Linux amd64 standard
  • Linux amd64 Docker
  • Linux arm64 standard
  • Linux arm64 Docker
  • Linux arm7 standard
  • Linux arm7 Docker
  • Linux arm6 standard
  • Linux arm6 Docker
  • [x ] Windows amd64 standard
  • Windows amd64 Docker (WSL backend)
  • macOS amd64 standard
  • macOS amd64 Docker
  • Other (please describe)

Describe the issue

[0.23.1 WebRTC-WHIP] It cannot work in the LAN. using chrome of pc or Android phone to push stream to the server.

Describe how to replicate the issue

  1. start the server
  2. publish with Chrome of on another pc by LAN: http://192.168.10.11:8889/mystream/publish
  3. it cannot work on chrome of pc or Android phone

Did you attach the server logs?

no

Did you attach a network dump?

no

@aler9
Copy link
Member

aler9 commented May 19, 2023

hello, can you attach server logs?

@aler9 aler9 added question Further information is requested webrtc labels May 19, 2023
@iesv
Copy link
Author

iesv commented May 19, 2023

sir, there is no log at all. it does not show info in console.

@aler9
Copy link
Member

aler9 commented Jun 2, 2023

Without server logs or any additional information it's not possible to replicate the issue.

@aler9 aler9 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
@UnKnoWn-Consortium
Copy link

You need HTTPS for WebRTC to work.

@iesv
Copy link
Author

iesv commented Jul 17, 2023

You need HTTPS for WebRTC to work.

Thank you very much! It works now even if it is not perfect.
42aca640cf9b28552cad4988162c60b

@UnKnoWn-Consortium
Copy link

UnKnoWn-Consortium commented Jul 18, 2023

You are welcome. Glad it works.

Yeah the interface does require some extra work. Pull requests are welcomed. Though it is not that hard to DIY your own by referring to the source code of the built-in page.

@aler9
Copy link
Member

aler9 commented Jul 18, 2023

I'll edit the default publish page in order to display an error whether device sharing is not allowed due to the fact that host is different than localhost and HTTPS is not enabled.

@aler9 aler9 added bug Something isn't working and removed question Further information is requested labels Jul 18, 2023
@iesv
Copy link
Author

iesv commented Jul 18, 2023

I'll edit the default publish page in order to display an error whether device sharing is not allowed due to the fact that host is different than localhost and HTTPS is not enabled.

Thank you aler9 so so much!!!

@aler9
Copy link
Member

aler9 commented Jul 19, 2023

added in v0.23.8

Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working webrtc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants