Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry log endpoint feature #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

landswellsong
Copy link

I've added an option to specify tlog: endpoints that would write incoming traffic in a Mavlink Logfile.

I thought it might be useful to make a PR of. It seems to be working alright, but my Go is very rusty (pun not intended) so I think the quality of the code can be improved.

In particular things I'm not very sure about:

  • Is it fine to lock up the Read() method like that? Ideally I'd pause that goroutine until the exit sequence, but I'm not very sure how to do that properly without altering gomavlib too much.
  • Does gomavlib issue writes in full packets? There seem to be some buffering involved, but I'm not entirely sure how Go's buffering operates. Currently my code assumes that the bytes to write is a whole single packet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant