Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix error message #634

Merged
merged 1 commit into from
Oct 14, 2024
Merged

server: fix error message #634

merged 1 commit into from
Oct 14, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Oct 13, 2024

Return error 'can't setup medias with different protocols' when trying to use UDP and TCP in sequence.

Return error 'can't setup medias with different protocols' when trying
to use UDP and TCP in sequence.
@aler9 aler9 force-pushed the fix/server-different-protocols branch from 3d03ece to 8736cbf Compare October 14, 2024 10:22
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.96%. Comparing base (ef77f78) to head (8736cbf).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server_session.go 70.58% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   81.91%   81.96%   +0.05%     
==========================================
  Files         116      116              
  Lines       11680    11685       +5     
==========================================
+ Hits         9568     9578      +10     
+ Misses       1726     1722       -4     
+ Partials      386      385       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit d43cce3 into main Oct 14, 2024
8 of 9 checks passed
@aler9 aler9 deleted the fix/server-different-protocols branch October 14, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant