Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SDP unmarshaling with some Chinese cameras (#201) #228

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 7, 2023

Fixes #201

@codecov-commenter
Copy link

Codecov Report

Merging #228 (fa688da) into main (1694d90) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   85.66%   85.67%   +0.01%     
==========================================
  Files          81       81              
  Lines        8720     8729       +9     
==========================================
+ Hits         7470     7479       +9     
  Misses        968      968              
  Partials      282      282              
Impacted Files Coverage Δ
pkg/sdp/sdp.go 91.69% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit d736f1d into main Apr 7, 2023
@aler9 aler9 deleted the bug-sdp branch April 7, 2023 13:05
@aler9
Copy link
Member Author

aler9 commented Apr 13, 2023

added in MediaMTX v0.22.1

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdp.Unmarshal returned Error
2 participants