update golangci-lint (#208)

bluenviron · Aug 4, 2024 · 8b429a4 · 8b429a4
1 parent e5d6ec0
commit 8b429a4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -19,7 +19,7 @@ jobs:
 
     - uses: golangci/golangci-lint-action@v3
       with:
-        version: v1.56.2
+        version: v1.59.1
 
   go-mod-tidy:
     runs-on: ubuntu-22.04

diff --git a/.golangci.yml b/.golangci.yml
@@ -14,9 +14,11 @@ linters:
   - misspell
   - nilerr
   - prealloc
+  - predeclared
   - revive
   - usestdlibvars
   - unconvert
+  - tenv
   - tparallel
   - wastedassign
   - whitespace

diff --git a/Makefile b/Makefile
@@ -1,5 +1,5 @@
 BASE_IMAGE = golang:1.22-alpine3.18
-LINT_IMAGE = golangci/golangci-lint:v1.56.2
+LINT_IMAGE = golangci/golangci-lint:v1.59.1
 
 .PHONY: $(shell ls)
 

diff --git a/node_test.go b/node_test.go
@@ -3,7 +3,6 @@ package goroslib
 import (
 	"net"
 	"net/http"
-	"os"
 	"os/exec"
 	"regexp"
 	"sort"
@@ -180,8 +179,7 @@ func TestNodeOpenErrors(t *testing.T) {
 
 func TestNodeNamespaceFromEnv(t *testing.T) {
 	t.Run("from environment", func(t *testing.T) {
-		os.Setenv("ROS_NAMESPACE", "/myns")
-		defer os.Unsetenv("ROS_NAMESPACE")
+		t.Setenv("ROS_NAMESPACE", "/myns")
 
 		m := newContainerMaster(t)
 		defer m.close()
@@ -197,8 +195,7 @@ func TestNodeNamespaceFromEnv(t *testing.T) {
 	})
 
 	t.Run("from environment and conf", func(t *testing.T) {
-		os.Setenv("ROS_NAMESPACE", "/myns1")
-		defer os.Unsetenv("ROS_NAMESPACE")
+		t.Setenv("ROS_NAMESPACE", "/myns1")
 
 		m := newContainerMaster(t)
 		defer m.close()