Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muxer: prevent creating empty parts before switching segments #184

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 29, 2024

No description provided.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 61.01695% with 46 lines in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (a6d4897) to head (6268d83).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
muxer_segmenter.go 55.43% 38 Missing and 3 partials ⚠️
muxer.go 50.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   71.85%   71.76%   -0.09%     
==========================================
  Files          58       58              
  Lines        3922     3885      -37     
==========================================
- Hits         2818     2788      -30     
+ Misses        912      908       -4     
+ Partials      192      189       -3     
Flag Coverage Δ
71.76% <61.01%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit a7b1616 into main Sep 29, 2024
6 of 8 checks passed
@aler9 aler9 deleted the feature/rotate-parts branch September 29, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant