Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update settings text #849

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Update settings text #849

merged 3 commits into from
Dec 5, 2023

Conversation

bradp
Copy link
Contributor

@bradp bradp commented Dec 5, 2023

Proposed changes

Update some of the settings text to improve the grammar and make them a bit more readable

Based on comments in #820

Screenshot 2023-12-05 at 9 44 21 AM

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Text update (minor)
  • [ ]

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Dec 5, 2023

5 failed and 1 flaky tests on run #5688 ↗︎

5 236 57 0 Flakiness 1

Details:

Fix linting
Project: Bluehost Brand Plugin Commit: 75fba6a61b
Status: Failed Duration: 16:06 💡
Started: Dec 5, 2023 3:36 PM Ended: Dec 5, 2023 3:53 PM
Failed  tests/cypress/integration/settings.cy.js • 1 failed test

View Output Video

Test Artifacts
Settings Page > Comment Settings Work Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-patterns/tests/cypress/integration/wonder-blocks.cy.js • 4 failed tests

View Output Video

Test Artifacts
Wonder Blocks > Wonder Blocks button exists Test Replay Screenshots Video
Wonder Blocks > Wonder Blocks button opens modal Test Replay Screenshots Video
Wonder Blocks > Close buttons closes modal Test Replay Screenshots Video
Wonder Blocks > ESC button closes modal too Test Replay Screenshots Video
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

Review all test suite changes for PR #849 ↗︎

Copy link

cypress bot commented Dec 5, 2023

5 failed and 1 flaky tests on run #5690 ↗︎

5 236 57 0 Flakiness 1

Details:

Merge 75fba6a into 191a2f4...
Project: Bluehost Brand Plugin Commit: 96aa156d3b ℹ️
Status: Failed Duration: 16:07 💡
Started: Dec 5, 2023 3:47 PM Ended: Dec 5, 2023 4:04 PM
Failed  tests/cypress/integration/settings.cy.js • 1 failed test

View Output Video

Test Artifacts
Settings Page > Comment Settings Work Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-patterns/tests/cypress/integration/wonder-blocks.cy.js • 4 failed tests

View Output Video

Test Artifacts
Wonder Blocks > Wonder Blocks button exists Test Replay Screenshots Video
Wonder Blocks > Wonder Blocks button opens modal Test Replay Screenshots Video
Wonder Blocks > Close buttons closes modal Test Replay Screenshots Video
Wonder Blocks > ESC button closes modal too Test Replay Screenshots Video
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

Review all test suite changes for PR #849 ↗︎

@circlecube
Copy link
Member

I'll merge this in and update the settings test in the release branch. (looks like it was looking for a string match that has now changed)

@circlecube circlecube merged commit 73106d1 into develop Dec 5, 2023
3 of 7 checks passed
@cypress cypress bot mentioned this pull request Dec 5, 2023
8 tasks
@wpscholar wpscholar deleted the feature/update-settings-text branch September 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants