Add module alias for cleaner imports #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluehost/bluehost-wordpress-plugin
|
|
I wonder if opening this PR on the Clean Up branch is better: https://github.com/bluehost/bluehost-wordpress-plugin/tree/update/react-app-cleanup since we are cleaning up the module imports there. Also, this might require some webpack/eslint config. |
|
@circlecube Personally, I'm a fan of the |
…eaner-imports * update/react-app-cleanup: Fix minor ESLint issue after PR merge Translate strings Fix linting Update console ascii art Update eslint.yml Remove example page Add php dependencies to eslint action Move handlePageLoad function to react hook ESLint action Fix webinar banner component lint issue Other lint fixes Add `eslint` and lint js files # Conflicts: # src/app/data/routes.js # webpack.config.js
1 flaky test on run #5477 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Help Page > Is Accessible |
Screenshots
Video
|
|
Review all test suite changes for PR #825 ↗︎
wpscholar
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds an alias and updates import statements for any module-based components or methods.
Type of Change
Checklist
Further comments