Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old mojo performance code (needs to be done across all brands) #771

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

wpscholar
Copy link
Member

Proposed changes

Removes old mojo performance toggle code.

We need to implement this change on other brands as well.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Documentation Update (if none of the other choices apply)

@wpscholar wpscholar self-assigned this Oct 27, 2023
Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! How did you realize this we still here? Is it conflicting with the performance module code?

@wpscholar
Copy link
Member Author

@circlecube I was digging into some EPC conflicts. Do you mind making yourself a reminder to remove this from the other plugins and blueprint?

@circlecube
Copy link
Member

Noted PRESS1-213

@circlecube circlecube changed the base branch from main to develop October 27, 2023 22:34
@circlecube circlecube merged commit 2c9067f into develop Oct 27, 2023
26 checks passed
@circlecube circlecube deleted the remove/old-performance-code branch October 27, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants