Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file-based caching #718

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Remove file-based caching #718

merged 3 commits into from
Oct 10, 2023

Conversation

wpscholar
Copy link
Member

Proposed changes

Remove file-based caching as an option in the Bluehost plugin. Adds an upgrade routine to remove the .htaccess rules and flush the file-based cache.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@wpscholar wpscholar self-assigned this Oct 10, 2023
@circlecube circlecube changed the base branch from main to develop October 10, 2023 15:19
@replay-io
Copy link

replay-io bot commented Oct 10, 2023

1 replays were recorded for 0006357.

image 1 Failed
  • vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js
    1. Coming Soon Toggle Functions
      AssertionError: Timed out retrying after 4000ms: Expected to find content: 'Maintenance Mode' within the element: <div#coming-soon-section.wppbh-app-section-content.nfd-p-8.nfd-pb-0.wppbh-app-settings-coming-soon> and with the selector: 'h3' but never did.
          at Context.eval (webpack:///./vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js:21:50)
    2. Coming Soon Toggle Functions
      AssertionError: Timed out retrying after 4000ms: Expected to find content: 'Maintenance Mode' within the element: <div#coming-soon-section.wppbh-app-section-content.nfd-p-8.nfd-pb-0.wppbh-app-settings-coming-soon> and with the selector: 'h3' but never did.
          at Context.eval (webpack:///./vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js:21:50)
    3. Displays Coming Soon in Site Status Admin Toolbar
    4. Has Coming Soon Section on Home
    5. Displays admin coming soon notice
    6. Displays Coming Soon on Frontend
    7. Launching launches site
image 0 Passed

View test run on Replay ↗︎

@circlecube
Copy link
Member

Again, all looks good except the single coming soon test that fails still. Will have it fixed in an upcoming PR.

@circlecube circlecube merged commit a70888e into develop Oct 10, 2023
27 of 28 checks passed
@circlecube circlecube deleted the update/remove-file-caching branch October 10, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants