Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Update #624

Merged
merged 20 commits into from
Aug 29, 2023
Merged

UI Update #624

merged 20 commits into from
Aug 29, 2023

Conversation

circlecube
Copy link
Member

@circlecube circlecube commented Aug 18, 2023

  • replace yoast ui library with newfold ui component library
  • update tailwind config and pcss
  • update classes from yst to nfd
  • update marketplace module to use update components sourced from the module

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

update tailwind config and pcss
update classes from yst to nfd
@circlecube circlecube self-assigned this Aug 18, 2023
@circlecube circlecube changed the title replace yaost ui library with newfold ui component library UI Update Aug 18, 2023
@replay-io
Copy link

replay-io bot commented Aug 18, 2023

1 replays were recorded for b5e9543.

image 1 Failed
  • vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js
    1. Coming Soon Toggle Functions
    2. Displays Coming Soon in Site Status Admin Toolbar
    3. Has Coming Soon Section on Home
      AssertionError: Timed out retrying after 4000ms: Expected to find content: 'Preview your' within the element: <div.wppb-app-section-content.yst-p-8.yst-pb-0> and with the selector: 'a.nfd-button' but never did.
    4. Displays admin coming soon notice
    5. Displays Coming Soon on Frontend
    6. Launching launches site
image 0 Passed

View test run on Replay ↗︎

@circlecube
Copy link
Member Author

Some tests are failing because they reference elements via class names which changed from .yst-* to .nfd-*. There are PRs in place to fix those modules:

There is also a PR to update the library in the e-commerce module. It is the only module currently using the yoast UI library.

All these other PRs will need to be approved, merged and new module versions will need to be tagged and released and those updates pulled into this branch/PR.

  - Upgrading newfold-labs/wp-module-coming-soon (1.1.7 => 1.1.8)
  - Upgrading newfold-labs/wp-module-ctb (1.0.1 => 1.0.2)
  - Upgrading newfold-labs/wp-module-staging (1.0.3 => 1.0.4)
@circlecube
Copy link
Member Author

The only remaining failing test is due to the e-commerce module still containing the .yst- classes where the style here is looking for .nfd-. Once this (newfold-labs/wp-module-ecommerce#117) is merged and released, we'll need to bump the module version here and the test should pass then.

@circlecube
Copy link
Member Author

The only remaining failing test is due to the e-commerce module still containing the .yst- classes where the style here is looking for .nfd-. Once this (newfold-labs/wp-module-ecommerce#117) is merged and released, we'll need to bump the module version here and the test should pass then.

The new PR to update e-commerce module to use the new library here: newfold-labs/wp-module-ecommerce#120 We need it reviewed and approved and a module version tagged and released so we can bump it here. This needs to be ready so we can prep the plugin release this week.

@circlecube circlecube merged commit b5895b5 into develop Aug 29, 2023
@circlecube circlecube deleted the update/use-newfold-ui-library branch August 29, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants