Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Component: Unify frontend render #61

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Conversation

0aveRyan
Copy link
Contributor

@0aveRyan 0aveRyan commented Nov 13, 2020

Proposed changes

  • Unify buttons to mirror Bluebird UI buttons render and transitions.
  • Add some !important guardrails (🙈 ) to be more future-proof for Core changes.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Notes

  • The Bluebird link button styles have extremely little contrast on the hover/active states and are almost impossible to distinguish.
  • Buttons should only have one prop for primary vs. secondary vs. link

@wpscholar wpscholar merged commit 492b636 into master Nov 16, 2020
@wpscholar wpscholar deleted the fix/buttons-audit branch November 16, 2020 19:16
This was referenced Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants