Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging api fetch helper: append the path after the url returns from runtime #578

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

circlecube
Copy link
Member

Tweak the way staging rest api urls are passed now that we're using runtime.

In my testing this appears to be all we need to change in order for urls to work properly for switching to/from staging environments. This appends the path to the api url once we get it rather than passing the whole path to the runtime createApiUrl helper.

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Aug 1, 2023
@circlecube circlecube changed the base branch from main to develop August 1, 2023 22:05
@replay-io
Copy link

replay-io bot commented Aug 1, 2023

php-7.1, wp-6.1

1 replays were recorded for 81b5f50.

image 1 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
image 0 Passed

View test run on Replay ↗︎

php-7.1, wp-6.2

1 replays were recorded for 81b5f50.

image 1 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
image 0 Passed

View test run on Replay ↗︎

php-7.2, wp-6.2

1 replays were recorded for 81b5f50.

image 1 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
image 0 Passed

View test run on Replay ↗︎

php-7.3, wp-6.1

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

php-7.3, wp-6.2

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

php-7.4, wp-6.1

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

php-7.4, wp-6.2

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

php-8.0, wp-6.1

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

php-8.0, wp-6.2

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

php-8.1, wp-6.1

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

php-8.1, wp-6.2

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

php-8.2, wp-6.1

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

php-8.2, wp-6.2

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

Main Test Suite

2 replays were recorded for 81b5f50.

image 2 Failed
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/2-general-onboarding-flow/basic-info.cy.js
    1. Check Drawer Activity
    2. Check if Header and Subheader shows up
      AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-scroll-container>' not to be 'visible'
    3. Check to make sure sidebar opens, content is in place and close sidebar
    4. Check if Header has text `website` in it
    5. Enter a Title and then Check if it reflects elsewhere
    6. Enter a Desc and then Check if it reflects elsewhere
    7. Check if Social Media Accordion Toggles
      AssertionError: Timed out retrying after 4000ms: expected '<div.social-form__label_name>' to be 'visible'
    8. Check if Social Media URL checks are done
    9. Check if Image gets Uploaded
  • tests/cypress/integration/z-newfold-labs/wp-module-onboarding/3-ecommerce-onboarding-flow/get-started-welcome.cy.js
    1. Change tab and check
    2. Check Exit to Wordpress button is visible and clickable and continue flow
    3. Check Exit to Wordpress button is visible and clickable and cancel
    4. Check if the Suppressed Drawer does not open on clicking Toggle Button
    5. Check to make sure sidebar opens, content is in place and close sidebar
    6. Check if welcome card is visible
    7. Check if main heading and sub heading shows up
    8. Check for brandname in sub heading
    9. Check if `store` appears in heading
    10. Check navigation back is not visible
    11. Check if next step loads on clicking navigation next
    12. Check Exit to Wordpress button is visible and clickable and exit flow
      AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-onboarding-etw__trigger`, but never found it.
image 0 Passed

View test run on Replay ↗︎

@aulisius
Copy link
Contributor

aulisius commented Aug 2, 2023

Other option which introduces more change but is also possible, is modifying the signature of stagingApiFetch

const stagingApiFetch = (
  { path = "", qs = {} },
  method = "GET",
  thenCallback,
  errorCallback = catchError
) => {
  // setIsError( false );
  // setIsLoading( true );
  setIsThinking(true);
  return apiFetch({
    url: NewfoldRuntime.createApiUrl(apiNamespace + path, qs),
    method,
    // beforeSend: (xhr) => {
    // 	xhr.setRequestHeader( 'X-WP-Nonce', restnonce );
    // },
  })
    .then((response) => {
      thenCallback(response);
    })
    .catch((error) => {
      errorCallback(error);
    });
};

and then we can use it as

stagingApiFetch({ path: `staging/switch-to`, qs: { env } }, "GET", callback);

@circlecube
Copy link
Member Author

stagingApiFetch({ path: `staging/switch-to`, qs: { env } }, "GET", callback);

Thanks for the suggestion @aulisius - I like this better, I'll get it in place before merging.

@circlecube circlecube merged commit d03ce6f into develop Aug 2, 2023
@circlecube circlecube deleted the fix/staging-api-urls branch August 2, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants