Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/modules #504

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Update/modules #504

merged 5 commits into from
Jun 20, 2023

Conversation

circlecube
Copy link
Member

@circlecube circlecube commented Jun 20, 2023 •
edited
Loading

Proposed changes

Update modules and packages as appropriate:

  • ecommerce: 1.0.2 > 1.0.5
  • onboarding: 1.8.1 > 1.8.2
  • react-router-dom: 6.12.1 > 6.13.0
  • replayio/cypress: 1.0.0 > 1.0.2
  • wp-env: 8.1.0 < 5.16.0

The wp-env still has issues with our tests so I'm rolling back to 5.16.0 (same happened on other plugins already)

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested review from earnjam and wpalani June 20, 2023 16:18
aulisius
aulisius approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@aulisius aulisius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing #500 in favor of this

@circlecube circlecube merged commit f41ff42 into develop Jun 20, 2023
@circlecube circlecube deleted the update/modules branch June 20, 2023 19:25
@arunshenoy99
Copy link
Member

Thank you for fixing the test @circlecube 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulisius aulisius aulisius approved these changes

@earnjam earnjam Awaiting requested review from earnjam

@wpalani wpalani Awaiting requested review from wpalani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@circlecube @arunshenoy99 @aulisius