Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.13.3 #406

Merged
merged 20 commits into from
Apr 26, 2023
Merged

Release/2.13.3 #406

merged 20 commits into from
Apr 26, 2023

Conversation

circlecube
Copy link
Member

@circlecube circlecube commented Apr 25, 2023

Proposed changes

Thus far this release:

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@replay-io
Copy link

replay-io bot commented Apr 25, 2023

3 replays were recorded for a06fc3f.

image 3 Failed
    tests/cypress/integration/z-newfold-labs/wp-module-onboarding/steps/ecommerce/address.cy.js
          <li>Check Drawer Activity
          
          ```
          AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-inner>' to be 'visible'
          ```
          </li>
          
          <li>Check to make sure sidebar opens, content is in place and close sidebar
          
          </li>
          
          <li>Checks if Heading and Subheading are present
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-step-card-heading`, but never found it.
          ```
          </li>
          
          <li>Checks if all the inputs are enabled
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `select[name="country"]`, but never found it.
          ```
          </li>
          
          <li>Checks if there are the correct number of countries
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `select[name="country"]`, but never found it.
          ```
          </li>
          
          <li>Populates the correct number of states for a country
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `select[name="country"]`, but never found it.
          ```
          </li>
          
          <li>Checks if there are the correct number of currencies
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `select[name="woocommerce_currency"]`, but never found it.
          ```
          </li>
          
          <li>Checks existence of Need Help Tag
          
          </li>
          
          <li>Checks existence of Need Help URL
          
          </li>
          
          <li>Checks if Continue Setup exists and is enabled
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-nav-card-button`, but never found it.
          ```
          </li>
          
          <li>Goes to next step on Continue Setup
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-nav-card-button`, but never found it.
          ```
          </li>
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/5768dcb1-226e-43ad-9d66-0047c6139fe8>tests/cypress/integration/z-newfold-labs/wp-module-onboarding/steps/ecommerce/products.cy.js</a></summary>
        <ol type="1">
          
          <li>Check Drawer Activity
          
          ```
          AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-inner>' to be 'visible'
          ```
          </li>
          
          <li>Check to make sure sidebar opens, content is in place and close sidebar
          
          </li>
          
          <li>Checks if Heading and Subheading are present
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-step-card-heading`, but never found it.
          ```
          </li>
          
          <li>Checks if there are the correct number of product checkboxes.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-product-step-options`, but never found it.
          ```
          </li>
          
          <li>Checks if there are the correct number of product count radio controls.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.step-product-numbers`, but never found it.
          ```
          </li>
          
          <li>Checks if all the product checkboxes are enabled.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-product-step-options`, but never found it.
          ```
          </li>
          
          <li>Checks if all the product count radio controls are enabled and checked.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.components-radio-control__option`, but never found it.
          ```
          </li>
          
          <li>Checks if all the product checkboxes can be checked.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.components-checkbox-control__input-container`, but never found it.
          ```
          </li>
          
          <li>Checks existence of Need Help Tag.
          
          </li>
          
          <li>Checks existence of Need Help URL.
          
          </li>
          
          <li>Goes to next step on Continue Setup.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-nav-card-button`, but never found it.
          ```
          </li>
        </ol>
      </details>
      <details>
        <summary><a href=https://app.replay.io/recording/98d5cafb-5321-4771-8d3a-3d4a0c790b89>tests/cypress/integration/z-newfold-labs/wp-module-onboarding/steps/ecommerce/tax-info.cy.js</a></summary>
        <ol type="1">
          
          <li>Check Drawer Activity
          
          ```
          AssertionError: Timed out retrying after 4000ms: expected '<div.nfd-onboarding-drawer__panel-inner>' to be 'visible'
          ```
          </li>
          
          <li>Check to make sure sidebar opens, content is in place and close sidebar
          
          </li>
          
          <li>Checks if Heading and Subheading are present.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-step-card-heading`, but never found it.
          ```
          </li>
          
          <li>Checks if Continue Setup is disabled.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.nfd-nav-card-button`, but never found it.
          ```
          </li>
          
          <li>Checks if there are the correct number of tax preference radio controls.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `.components-radio-control__option`, but never found it.
          ```
          </li>
          
          <li>Checks if all the tax preference radio control buttons are enabled and clickable.
          
          ```
          AssertionError: Timed out retrying after 4000ms: Expected to find element: `[type="radio"]`, but never found it.
          ```
          </li>
          
          <li>Checks existence of Need Help Tag.
          
          </li>
          
          <li>Checks existence of Need Help URL.
          
          </li>
          
          <li>Goes to the next step on clicking navigation Next.
          
          </li>
        </ol>
      </details>
      
image 0 Passed

View test run on Replay ↗︎

@what-the-diff
Copy link

what-the-diff bot commented Apr 26, 2023

PR Summary

  • Removed CTB module
    CTB module has been removed from the project
  • Updated version number
    Version number has been updated to 2.13.3
  • Newfold-plugin script handling
    Added handling for newfold-plugin script in admin assets and implemented inline scripts for global JavaScript values
  • Modified marketplace page
    Marketplace page now uses a dedicated supportsCTB value from the nfdctb object instead of directly referring to the window variable
  • Adjusted branding test
    Updated test for checking branding between Newfold and Bluehost, as the brand is now set from the plugin container rather than relying on the mm_brand option from the database

@circlecube
Copy link
Member Author

This release satisfies #379

@circlecube circlecube merged commit 2f8ee06 into master Apr 26, 2023
@circlecube circlecube deleted the release/2.13.3 branch April 26, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants