Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump onboarding version from 1.3.0 to 1.4.0 #399

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Bump onboarding version from 1.3.0 to 1.4.0 #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14187a1
Bump Onboarding Version to 1.4.0
abhijitb Apr 20, 2023
a452c2e
fixing test when mm_brand does not exist in DB
abhijitb Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"newfold-labs/wp-module-loader": "^1.0.10",
"newfold-labs/wp-module-marketplace": "^1.5.0",
"newfold-labs/wp-module-notifications": "^1.1.2",
"newfold-labs/wp-module-onboarding": "1.3.0",
"newfold-labs/wp-module-onboarding": "1.4.0",
"newfold-labs/wp-module-secure-passwords": "^1.1",
"newfold-labs/wp-module-sso": "^1.0.3",
"wp-forge/collection": "^1.0.2",
Expand Down
14 changes: 7 additions & 7 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions tests/cypress/integration/z-newfold-labs/wp-module-onboarding/branding.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@ describe( 'Branding', function () {
cy.visit( 'wp-admin/index.php?page=nfd-onboarding&flow=ecommerce' );
} );

it( 'Has Newfold CSS when mm_brand does not exist.', () => {
// since we are setting brand from plugin container, it will not be set to "newfold"
// by default even if mm_brand option is deleted from the database
it( 'Has Bluehost CSS when mm_brand does not exist.', () => {
cy.exec( 'npx wp-env run cli wp option delete mm_brand' );
cy.reload();
cy.get( 'body' ).should( 'have.class', 'nfd-brand-newfold' );
cy.get( 'body' ).should( 'have.class', 'nfd-brand-bluehost' );
cy.get( '.is-bg-primary' )
.should( 'have.css', 'background-color', 'rgb(221, 82, 40)' )
.should( 'have.css', 'color', 'rgb(242, 242, 242)' );
cy.get( '.nfd-step-card-subheading' ).should( 'contain', 'undefined' );
.should( 'have.css', 'background-color', 'rgb(53, 117, 211)' )
.should( 'have.css', 'color', 'rgb(255, 255, 255)' );
cy.get( '.nfd-step-card-subheading' ).should( 'contain', 'Bluehost' );
} );

it( 'Has Newfold CSS when mm_brand has an empty value', () => {
Expand Down