Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jarvis detection logic #397

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Apr 18, 2023

Since now the .host-info file is moved to the host root we are updating the detection method.

We are also detecting using the file system instead of database check.

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Since now the .host-info file is moved to the host root we are updating the detection method.

We are also detecting using the file system instead of database check.
@wpalani wpalani requested review from circlecube and earnjam April 18, 2023 19:07
Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I do wonder if we should store it in a transient for a while rather than looking up the file on every page load. (Even if it's just an hour)

@circlecube circlecube merged commit eb7e143 into develop Apr 18, 2023
@circlecube circlecube deleted the update-jarvis-detection branch April 18, 2023 21:05
@circlecube circlecube mentioned this pull request Apr 18, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants