Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically run matrix on release branch PRs #393

Merged
merged 2 commits into from
Apr 14, 2023
Merged

automatically run matrix on release branch PRs #393

merged 2 commits into from
Apr 14, 2023

Conversation

circlecube
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpscholar April 12, 2023 18:14
wpscholar
wpscholar approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@circlecube I'm fine with pulling out the run after a release is published.

@circlecube
remove matrix on release
fc04917 
this is no longer needed if we run it on release PR
@circlecube circlecube merged commit 424cf27 into master Apr 14, 2023
@circlecube circlecube deleted the update/run-matrix-on-release-pr branch April 14, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @wpscholar