Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jarvis links detection method #388

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Update Jarvis links detection method #388

merged 1 commit into from
Apr 11, 2023

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Apr 11, 2023

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpalani wpalani requested a review from circlecube April 11, 2023 19:11
@wpscholar wpscholar merged commit ffa3f37 into develop Apr 11, 2023
@wpscholar wpscholar deleted the update-jarvis-links-detection-logic branch April 11, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpalani @circlecube @wpscholar