Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/package cleanup #368

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Update/package cleanup #368

merged 5 commits into from
Apr 3, 2023

Conversation

circlecube
Copy link
Member

@circlecube circlecube commented Mar 31, 2023

Proposed changes

Looking through the dependabot PRs and noticed that we weren't even using some of those packages. I closed them and this PR removes the packages and updates a couple others in one PR, the other dependabot PRs should self-close once this one is approved and merged into dev branch.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpscholar March 31, 2023 20:47
@circlecube circlecube self-assigned this Mar 31, 2023
@circlecube circlecube requested a review from wpalani March 31, 2023 20:47
@@ -62,20 +60,19 @@
"cypress-axe": "^1.4.0",
"file-loader": "^6.2.0",
"filemanager-webpack-plugin": "^8.0.0",
"husky": "^6.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to use this to run pre-commit hooks. This automated local linting and POT file updates. I feel like it could still be a helpful tool.

@circlecube circlecube merged commit cec88be into develop Apr 3, 2023
@circlecube circlecube deleted the update/package-cleanup branch April 3, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants