Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Site Generation Capability Failures: Update wp-module-onboarding and wp-module-onboarding-data #1434

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

0aveRyan
Copy link
Contributor

Proposed changes

Both these changes are required to address the problems in production with AI Site Generation.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@0aveRyan 0aveRyan changed the title Update wp-module-onboarding and wp-module-onboarding-data Address Site Generation Capability Failures: Update wp-module-onboarding and wp-module-onboarding-data Nov 22, 2024
Copy link

cypress bot commented Nov 22, 2024

Bluehost Brand Plugin    Run #11788

Run Properties:  status check failed Failed #11788  •  git commit b13994ea7f ℹ️: Merge e9d48a59e4e1bc61f0e9f2252021f2dc1b3c1339 into d7999bdff1440c7d490a997aa95e...
Project Bluehost Brand Plugin
Branch Review fix/sitegen-onboarding
Run status status check failed Failed #11788
Run duration 32m 27s
Commit git commit b13994ea7f ℹ️: Merge e9d48a59e4e1bc61f0e9f2252021f2dc1b3c1339 into d7999bdff1440c7d490a997aa95e...
Committer Dave Ryan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 8
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 405
View all changes introduced in this branch ↗︎

Tests for review

Failed  basic-info.cy.js • 1 failed test

View Output Video

Test Artifacts
Basic Info Page > Test Basic Info Events API gets triggered Test Replay Screenshots Video
Failed  get-started-experience.cy.js • 1 failed test

View Output Video

Test Artifacts
Start Setup WP Experience Page > Check if `site` appears in heading Test Replay Screenshots Video
Failed  get-started-welcome.cy.js • 1 failed test

View Output Video

Test Artifacts
Get Started Welcome Page > Check if `website` appears in heading Test Replay Screenshots Video
Failed  sitetype-primary.cy.js • 1 failed test

View Output Video

Test Artifacts
Get Started Site Type Primary > Check to make sure sidebar opens, content is in place and close sidebar Test Replay Screenshots Video
Failed  sitetype-secondary.cy.js • 1 failed test

View Output Video

Test Artifacts
Get Started Site Type Secondary > Check to make sure sidebar opens, content is in place and close sidebar Test Replay Screenshots Video

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/basic-info.cy.js • 1 flaky test

View Output Video

Test Artifacts
Basic Info Page > Check Drawer Activity Test Replay Screenshots Video

@circlecube circlecube merged commit 70b9255 into release/3.15.5 Nov 22, 2024
1 of 6 checks passed
@circlecube circlecube deleted the fix/sitegen-onboarding branch November 22, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants