Fix/plugins loaded priority for cache types #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
fix/plugins_loaded_priority_for_cache_types
|
| Run status |
|
| Run duration | 29m 12s |
| Commit |
|
| Committer | Armando Liccardo |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
33
|
Skipped
|
0
|
Passing
|
410
|
| View all changes introduced in this branch ↗︎ | |
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
fix/plugins_loaded_priority_for_cache_types
|
| Run status |
|
| Run duration | 29m 21s |
| Commit |
|
| Committer | Armando Liccardo |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
1
|
|
Pending
|
33
|
|
Skipped
|
0
|
|
Passing
|
410
|
| View all changes introduced in this branch ↗︎ | |
|
@geckod22 - Was this branch based on the main branch or another branch? It seems to have picked up a lot of other things. |
wpscholar
approved these changes
Nov 14, 2024
circlecube
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
On bootstrap.php the cache_types is added to the container in the action plugins_loaded with priority 11, but this fire after the performance module so that information is not present when the performance module check for that datas. Removing the priority will provide the needed information and the getContext also seem to work normally.
Due to data not present, the cache types classes are not correctly loaded, se when one changes the level cache option in the Perfomance panel the event will not trigger the Option listeners and no changes apply.
Type of Change
Checklist
Further comments