Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove my products module #1375

Merged
merged 1 commit into from
Oct 25, 2024
Merged

remove my products module #1375

merged 1 commit into from
Oct 25, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

This module is no longer used, this removes it as a dependency.

See: newfold-labs/wp-module-my-products#11

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube
remove my products module
069897d 
this module is no longer used
@circlecube circlecube self-assigned this Oct 25, 2024
@cypress Cypress
Copy link

cypress bot commented Oct 25, 2024

Bluehost Brand Plugin    Run #11287

Run Properties:  status check passed Passed #11287  •  git commit 069897d699: remove my products module
Project Bluehost Brand Plugin
Branch Review update/my-products-module
Run status status check passed Passed #11287
Run duration 27m 13s
Commit git commit 069897d699: remove my products module
Committer Evan Mullins
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Oct 25, 2024

Bluehost Brand Plugin    Run #11288

Run Properties:  status check failed Failed #11288  •  git commit 45d5994588 ℹ️: Merge 069897d699ec0e24b9bbb6419d22f0a1fc416c77 into 56a55497e6997e4624dbef7da0ea...
Project Bluehost Brand Plugin
Branch Review update/my-products-module
Run status status check failed Failed #11288
Run duration 27m 16s
Commit git commit 45d5994588 ℹ️: Merge 069897d699ec0e24b9bbb6419d22f0a1fc416c77 into 56a55497e6997e4624dbef7da0ea...
Committer Evan Mullins
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 415
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/integration/help.cy.js • 1 failed test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

@circlecube circlecube merged commit 8a33233 into develop Oct 25, 2024
3 of 5 checks passed
@circlecube circlecube deleted the update/my-products-module branch October 25, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

@abhijitb abhijitb Awaiting requested review from abhijitb

@wpalani wpalani Awaiting requested review from wpalani

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @wpscholar