Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRESS0-2212: Import WP Solutions Banner on Home page #1307

Merged
merged 8 commits into from
Oct 9, 2024
Merged

PRESS0-2212: Import WP Solutions Banner on Home page #1307

merged 8 commits into from
Oct 9, 2024

Conversation

aratidgr8
Copy link
Contributor

Proposed changes

JIRA: https://jira.newfold.com/browse/PRESS0-2212
Import WP Solutions Banner Component on Home page.
Refer to PR for more details.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@cypress Cypress
Copy link

cypress bot commented Sep 11, 2024 •
edited
Loading

Bluehost Brand Plugin    Run #10385

Run Properties:  status check failed Failed #10385  •  git commit 2307298b65 ℹ️: Merge abba1e41a109a5cc39110b05bcce5324216b2257 into 5b2ce9df719501ea1e4789b2831f...
Project Bluehost Brand Plugin
Branch Review PRESS0-2212
Run status status check failed Failed #10385
Run duration 17m 26s
Commit git commit 2307298b65 ℹ️: Merge abba1e41a109a5cc39110b05bcce5324216b2257 into 5b2ce9df719501ea1e4789b2831f...
Committer Arati Bhandare
View all properties for this run ↗︎
Test results
Tests that failed  Failures 40
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 85
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/integration/home.cy.js • 6 failed tests

View Output Video

Test Artifacts
Home Page > Is Accessible Test Replay Screenshots Video
Home Page > Welcome Section Exists Test Replay Screenshots Video
Home Page > Account Section Exists Test Replay Screenshots Video
Home Page > Help Section Exists Test Replay Screenshots Video
Home Page > Webinars Section Exists Test Replay Screenshots Video
Home Page > Webinars Section Renders Correctly Test Replay Screenshots Video
Failed  tests/cypress/integration/navigation.cy.js • 3 failed tests

View Output Video

Test Artifacts
Navigation > Logo Links to home Test Replay Screenshots Video
Navigation > Main nav links properly navigates Test Replay Screenshots Video
Navigation > Subnav links properly navigates Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 1 failed test

View Output Video

Test Artifacts
Coming Soon > Has Coming Soon Section on Home Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/ecommerce-coming-soon.cy.js • 4 failed tests

View Output Video

Test Artifacts
e-commerce Home Page- Coming soon mode > Verify Congrats on your new site message, coming soon alert Test Replay Screenshots Video
e-commerce Home Page- Coming soon mode > Verify Site Preview flex and View your site option Test Replay Screenshots Video
e-commerce Home Page- Coming soon mode > Verify presense of Ready to go to live? canvas Test Replay Screenshots Video
e-commerce Home Page- Coming soon mode > Verify Visit your site and Launch your site functionality Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/ecommerce-live.cy.js • 2 failed tests

View Output Video

Test Artifacts
e-commerce Home Page- Live Mode > Verify presense of Ready to go to next level? canvas Test Replay Screenshots Video
e-commerce Home Page- Live Mode > Verify by default View Site option should be displayed Test Replay Screenshots Video

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

@wpscholar wpscholar changed the base branch from main to solutions September 18, 2024 15:29
@wpscholar
Merge branch 'solutions' into PRESS0-2212
a6265d0 
# Conflicts:
#	src/app/pages/home/index.js
@wpscholar
Copy link
Member

Running full test matrix now that the code conflicts have been resolved: https://github.com/bluehost/bluehost-wordpress-plugin/actions/runs/10925458847

@cypress Cypress
Copy link

cypress bot commented Sep 18, 2024 •
edited
Loading

Bluehost Brand Plugin    Run #10604

Run Properties:  status check failed Failed #10604  •  git commit 4ac5661d31: Increase wait time in Home & Help page cypress tests
Project Bluehost Brand Plugin
Branch Review PRESS0-2212
Run status status check failed Failed #10604
Run duration 17m 49s
Commit git commit 4ac5661d31: Increase wait time in Home & Help page cypress tests
Committer aratidgr8
View all properties for this run ↗︎
Test results
Tests that failed  Failures 40
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 85
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/integration/home.cy.js • 6 failed tests

View Output Video

Test Artifacts
Home Page > Is Accessible Test Replay Screenshots Video
Home Page > Welcome Section Exists Test Replay Screenshots Video
Home Page > Account Section Exists Test Replay Screenshots Video
Home Page > Help Section Exists Test Replay Screenshots Video
Home Page > Webinars Section Exists Test Replay Screenshots Video
Home Page > Webinars Section Renders Correctly Test Replay Screenshots Video
Failed  tests/cypress/integration/navigation.cy.js • 3 failed tests

View Output Video

Test Artifacts
Navigation > Logo Links to home Test Replay Screenshots Video
Navigation > Main nav links properly navigates Test Replay Screenshots Video
Navigation > Subnav links properly navigates Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-coming-soon/tests/cypress/integration/coming-soon.cy.js • 1 failed test

View Output Video

Test Artifacts
Coming Soon > Has Coming Soon Section on Home Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/ecommerce-coming-soon.cy.js • 4 failed tests

View Output Video

Test Artifacts
e-commerce Home Page- Coming soon mode > Verify Congrats on your new site message, coming soon alert Test Replay Screenshots Video
e-commerce Home Page- Coming soon mode > Verify Site Preview flex and View your site option Test Replay Screenshots Video
e-commerce Home Page- Coming soon mode > Verify presense of Ready to go to live? canvas Test Replay Screenshots Video
e-commerce Home Page- Coming soon mode > Verify Visit your site and Launch your site functionality Test Replay Screenshots Video
Failed  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/ecommerce-live.cy.js • 2 failed tests

View Output Video

Test Artifacts
e-commerce Home Page- Live Mode > Verify presense of Ready to go to next level? canvas Test Replay Screenshots Video
e-commerce Home Page- Live Mode > Verify by default View Site option should be displayed Test Replay Screenshots Video

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

@wpscholar
Copy link
Member

wpscholar commented Sep 18, 2024 •
edited
Loading

@aratidgr8 Let's look into why so many tests are failing: https://github.com/bluehost/bluehost-wordpress-plugin/actions/runs/10925458847

@aratidgr8
Copy link
Contributor Author

aratidgr8 commented Sep 20, 2024 •
edited
Loading

@wpscholar we are checking why tests are failing will keep you posted on updates. Attaching JIRA for your reference. Thanks!

@aratidgr8 aratidgr8 mentioned this pull request Sep 25, 2024
Merged
8 tasks
@krsomayagi
Copy link

The tests are failing because the ecommerce package is still on an older version, and the solutions banner import does not exist.

@aratidgr8
Copy link
Contributor Author

@aratidgr8 Let's look into why so many tests are failing: https://github.com/bluehost/bluehost-wordpress-plugin/actions/runs/10925458847

@wpscholar As confirmed by @krsomayagi in comment tests will pass once home page banner PR is merged. Please confirm in that case are we good to merge this PR then?

@wpscholar
Copy link
Member

@aratidgr8 Yes, let's merge both of those

@circlecube circlecube merged commit b67f8df into solutions Oct 9, 2024
@circlecube circlecube deleted the PRESS0-2212 branch October 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

@diwanshuster diwanshuster diwanshuster approved these changes

@wpscholar wpscholar Awaiting requested review from wpscholar

Assignees
No one assigned
Labels
Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aratidgr8 @wpscholar @krsomayagi @circlecube @diwanshuster @ramyakrishnai