Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRESS0-2122 | Updated Help Text in Side Nav Menu to open Helpcenter #1304

Merged
merged 2 commits into from
Sep 18, 2024
Merged

PRESS0-2122 | Updated Help Text in Side Nav Menu to open Helpcenter #1304

merged 2 commits into from
Sep 18, 2024

Conversation

ramyakrishnai
Copy link
Contributor

@ramyakrishnai ramyakrishnai commented Sep 10, 2024 •
edited
Loading

Proposed changes

  • PRESS0-2122 | Updated Help Text in Side Nav Menu to open Helpcenter
Screenshot 2024-09-10 at 12 42 16 PM

Replica of #1303

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@ramyakrishnai ramyakrishnai changed the title Update/press0-2122 PRESS0-2122 | Updated Help Text in Side Nav Menu to open Helpcenter Sep 10, 2024
@ramyakrishnai ramyakrishnai requested review from wpalani and circlecube and removed request for wpalani September 10, 2024 07:16
@cypress Cypress
Copy link

cypress bot commented Sep 10, 2024

Bluehost Brand Plugin    Run #10347

Run Properties:  status check passed Passed #10347  •  git commit 23cd6ec4da: Merge pull request #1303 from ajayadav09/PRESS0-2122-help-sidenav
Project Bluehost Brand Plugin
Branch Review update/PRESS0-2122
Run status status check passed Passed #10347
Run duration 26m 09s
Commit git commit 23cd6ec4da: Merge pull request #1303 from ajayadav09/PRESS0-2122-help-sidenav
Committer Ramya
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 418
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Sep 10, 2024

Bluehost Brand Plugin    Run #10349

Run Properties:  status check passed Passed #10349  •  git commit d5989c36cc ℹ️: Merge 23cd6ec4da5484feccef902363d7322a4f4d85df into 0bbd1890f7459571095e9b75eea6...
Project Bluehost Brand Plugin
Branch Review update/PRESS0-2122
Run status status check passed Passed #10349
Run duration 26m 15s
Commit git commit d5989c36cc ℹ️: Merge 23cd6ec4da5484feccef902363d7322a4f4d85df into 0bbd1890f7459571095e9b75eea6...
Committer Ramya
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 418
View all changes introduced in this branch ↗︎

@wpscholar wpscholar added this to the September 25 Release milestone Sep 18, 2024
@wpscholar wpscholar changed the base branch from develop to release/3.14.11 September 18, 2024 18:41
@wpscholar wpscholar merged commit 067377d into release/3.14.11 Sep 18, 2024
10 of 17 checks passed
@wpscholar wpscholar deleted the update/PRESS0-2122 branch September 18, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

@circlecube circlecube Awaiting requested review from circlecube

@wpalani wpalani Awaiting requested review from wpalani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
September 25 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ramyakrishnai @wpscholar @ajayadav09