Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS0-2200: Update add new post and page launchpads with wb params #1288

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

0aveRyan
Copy link
Contributor

@0aveRyan 0aveRyan commented Sep 3, 2024

This is not-urgent, doesn't need to go into 3.14.8, feel free to change base branch to future release.

Proposed changes

  • Appends URL query parameters to Launchpad links.
  • Does not check if WonderBlocks feature or module is active because in the event of not being active nothing about the Core experience changes with the extra query parameters.
  • Relies on newfold-labs/[email protected] #108 to function.

Post: wp-admin/post-new.php?wb-library=patterns&wb-category=text
Page: wp-admin/post-new.php?post_type=page&wb-library=patterns&wb-category=features

wp-admin-launchpad-page.mp4
wp-admin-launchpad-blog-post.mp4

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link

cypress bot commented Sep 3, 2024

Bluehost Brand Plugin    Run #10052

Run Properties:  status check passed Passed #10052  •  git commit 871624740f ℹ️: Merge 32863c12e18e26f39a2840da4fb49a45947e9c9f into 9bfeb4b18a20488c09a2a3773f39...
Project Bluehost Brand Plugin
Branch Review PRESS0-2200-use-wb-in-launchpads
Run status status check passed Passed #10052
Run duration 25m 51s
Commit git commit 871624740f ℹ️: Merge 32863c12e18e26f39a2840da4fb49a45947e9c9f into 9bfeb4b18a20488c09a2a3773f39...
Committer Dave Ryan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 418
View all changes introduced in this branch ↗︎

@circlecube circlecube added this to the September 11 Release milestone Sep 4, 2024
@wpalani wpalani merged commit a358b30 into release/3.14.8 Sep 4, 2024
3 checks passed
@wpalani wpalani deleted the PRESS0-2200-use-wb-in-launchpads branch September 4, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants