Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the site_capabilities filter #1260

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Moves the filter from the BH plugin's bootstrap.php file to the data module, where other filters are located, and includes the is_callable check. This approach is much safer.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Aug 16, 2024



Test summary

418 0 36 0Flakiness 0


Run details

Project Bluehost Brand Plugin
Status Passed
Commit 3a8dab9
Started Aug 16, 2024 2:42 PM
Ended Aug 16, 2024 3:08 PM
Duration 26:32 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

cypress bot commented Aug 16, 2024



Test summary

418 0 36 0Flakiness 0


Run details

Project Bluehost Brand Plugin
Status Passed
Commit 72528d0 ℹ️
Started Aug 16, 2024 8:07 AM
Ended Aug 16, 2024 8:37 AM
Duration 29:54 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@circlecube circlecube added this to the 3.14.4 - August 21 Release milestone Aug 16, 2024
@circlecube circlecube merged commit 39ae621 into release/3.14.4 Aug 16, 2024
3 checks passed
@circlecube circlecube deleted the fix/site-capability-transient-issue branch August 16, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants