Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Help Center to version 2.0.1 #1189

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

abhijitb
Copy link
Collaborator

@abhijitb abhijitb commented Jul 18, 2024

Proposed changes

With the release of WordPress 6.6, wp-polyfill has been removed from the React script dependency. This change was preventing the Help Center modal from appearing. A fix for this is mentioned here https://make.wordpress.org/core/2024/06/25/miscellaneous-developer-changes-in-wordpress-6-6/#obsolete-polyfills-dependencies-have-been-removed.

We have manually added regenerator-runtime library to the Help Center as recommended by the above link.

Jira Ticket : https://jira.newfold.com/browse/PRESS0-1793

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Jul 18, 2024

Passing run #9219 ↗︎

0 391 59 0 Flakiness 0

Details:

bump help center version to 2.01
Project: Bluehost Brand Plugin Commit: e58cf61198
Status: Passed Duration: 27:04 💡
Started: Jul 18, 2024 1:54 PM Ended: Jul 18, 2024 2:21 PM

Review all test suite changes for PR #1189 ↗︎

Copy link

cypress bot commented Jul 18, 2024

Passing run #9223 ↗︎

0 391 59 0 Flakiness 0

Details:

Merge e58cf61 into 0a05789...
Project: Bluehost Brand Plugin Commit: 81e3c92f27 ℹ️
Status: Passed Duration: 25:23 💡
Started: Jul 18, 2024 4:22 PM Ended: Jul 18, 2024 4:47 PM

Review all test suite changes for PR #1189 ↗︎

@wpalani wpalani changed the base branch from develop to release/3.13.2 July 18, 2024 16:19
@wpalani wpalani self-requested a review July 18, 2024 16:20
@wpalani wpalani added this to the July 24 Release milestone Jul 18, 2024
@wpalani wpalani merged commit 72db844 into release/3.13.2 Jul 18, 2024
6 of 7 checks passed
@wpalani wpalani deleted the fix/helpcenter-wordpress-6.6 branch July 18, 2024 17:02
@cypress cypress bot mentioned this pull request Jul 18, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants