Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add posts and pages page #1045

Merged
merged 26 commits into from
Apr 22, 2024
Merged

Add posts and pages page #1045

merged 26 commits into from
Apr 22, 2024

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Apr 22, 2024

Proposed changes

This PR builds on some work done in this PR: #1040 with few fixes:

  • Fix border and shadow styles in some of the feature cards.
  • Fix merge conflicts.
  • Remove packages that shouldn't be pushed in this PR or the other.
  • Rename page slug and file names.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpalani wpalani requested review from circlecube and wpscholar April 22, 2024 04:55
Copy link

cypress bot commented Apr 22, 2024

Passing run #8122 ↗︎

0 409 29 0 Flakiness 0

Details:

Rename test file name
Project: Bluehost Brand Plugin Commit: 9cf0d3683f
Status: Passed Duration: 22:13 💡
Started: Apr 22, 2024 4:51 AM Ended: Apr 22, 2024 5:13 AM

Review all test suite changes for PR #1045 ↗︎

Copy link

cypress bot commented Apr 22, 2024

Passing run #8123 ↗︎

0 409 29 0 Flakiness 0

Details:

Merge 9cf0d36 into a55bce0...
Project: Bluehost Brand Plugin Commit: c76152560c ℹ️
Status: Passed Duration: 24:07 💡
Started: Apr 22, 2024 4:58 AM Ended: Apr 22, 2024 5:22 AM

Review all test suite changes for PR #1045 ↗︎

@wpalani wpalani merged commit 0466331 into develop Apr 22, 2024
7 checks passed
@wpalani wpalani deleted the add/launchpad branch April 22, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants