Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow versioning non-published packages #20

Merged
merged 3 commits into from
Nov 9, 2024
Merged

feat: Allow versioning non-published packages #20

merged 3 commits into from
Nov 9, 2024

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Nov 9, 2024 •
edited
Loading

This is needed, e.g. when app developers create a common package for their needs, but isn't meant to be published to pub.dev.

Example workflow: https://github.com/Oberhauser-Dev/wrestling_scoreboard/actions/runs/11755620616/job/32750863728#step:4:258

@Gustl22 Gustl22 requested a review from spydon November 9, 2024 10:50
@Gustl22 Gustl22 marked this pull request as draft November 9, 2024 11:00
@Gustl22 Gustl22 removed the request for review from spydon November 9, 2024 11:01
spydon
spydon approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, any reason it is a draft?

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Nov 9, 2024

yes, i was missing that I had to enable this also for tags not just versioning. I test the workflow once more and change it to ready then.

@Gustl22 Gustl22 marked this pull request as ready for review November 9, 2024 12:27
@Gustl22
Copy link
Collaborator Author

Gustl22 commented Nov 9, 2024

Working now:
For Versioning: https://github.com/Oberhauser-Dev/wrestling_scoreboard/actions/runs/11756159038/job/32752016419#step:4:257
And for Tagging: https://github.com/Oberhauser-Dev/wrestling_scoreboard/actions/runs/11756185272/job/32752069550#step:4:251

@spydon spydon merged commit 68b03fa into main Nov 9, 2024
@Gustl22 Gustl22 deleted the version-private branch November 9, 2024 22:14
@spydon
Copy link
Member

spydon commented Nov 13, 2024

@Gustl22 I updated the v3 tag and created v3.1.0, both including your change.

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Nov 13, 2024 •
edited
Loading

Oh thank you, I sneakily pushed the v3 tag a few days ago also with my commit. I hope that was ok.

@spydon
Copy link
Member

spydon commented Nov 13, 2024

Oh thank you, I sneakily pushed the v3 tag a few days ago also with my commit. I hope that was ok.

Hahah aaah, that explains why my terminal said that the v3 tag was already up to date 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustl22 @spydon