EDG-13557: GET method #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leshow
approved these changes
Nov 24, 2023
|
Looks fine to me, you may want to add some description in the PR though |
| plugin.next.ServeHTTP(rw, req) | ||
| } | ||
|
|
||
| func (plugin AwsPlugin) put(rw http.ResponseWriter, req *http.Request) { |
There was a problem hiding this comment.
put is implemented for AwsPlugin but get is implemented for *AwsPlugin. Is that intentional?
abrener5735
reviewed
Nov 27, 2023
| @@ -39,13 +40,34 @@ type AwsPlugin struct { | |||
| } | |||
|
|
|||
| func (plugin AwsPlugin) ServeHTTP(rw http.ResponseWriter, req *http.Request) { | |||
| switch req.Method { | |||
| case "PUT": | |||
There was a problem hiding this comment.
Should use http.MethodPut and http.MethodGet
| handleResponse(resp, err, rw) | ||
| } | ||
|
|
||
| func handleResponse(resp []byte, err error, rw http.ResponseWriter) { |
There was a problem hiding this comment.
Can be confusing to use the name err as an argument and internal variable. I would rename the argument, maybe to requestErr
| req, err := http.NewRequest("PUT", uri, bytes.NewReader(payload)) | ||
| var payloadReader io.Reader = nil | ||
| if payload != nil { | ||
| payloadReader = bytes.NewReader(payload) |
There was a problem hiding this comment.
Given that the payload may be big, it may be more efficient to use bufio.NewReader(..)
| @@ -66,6 +72,14 @@ func (s3 *S3) Put(name string, payload []byte, contentType string, rw http.Respo | |||
| return response, nil | |||
| } | |||
|
|
|||
| func (s3 *S3) Put(name string, payload []byte, contentType string, rw http.ResponseWriter) ([]byte, error) { | |||
| return s3.request("PUT", name, payload, contentType, rw) | |||
There was a problem hiding this comment.
Should use http.MethodPut and http.MethodGet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement GET method for S3 and local directory services