Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EOF): Use cfg code size limit for eofcreate #1606

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

rakita
Copy link
Member

@rakita rakita commented Jul 12, 2024

Respect cfg code size for eofcreate output

Copy link
Contributor

github-actions bot commented Jul 12, 2024

Valgrind Results:

==3945== Cachegrind, a cache and branch-prediction profiler
==3945== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3945== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3945== Command: target/release/snailtracer
==3945== 
--3945-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.836458623s
==3945== 
==3945== I   refs:      427,042,385
==3945== I1  misses:          7,836
==3945== LLi misses:          2,833
==3945== I1  miss rate:        0.00%
==3945== LLi miss rate:        0.00%
==3945== 
==3945== D   refs:      204,077,697  (132,269,238 rd   + 71,808,459 wr)
==3945== D1  misses:        340,297  (    200,333 rd   +    139,964 wr)
==3945== LLd misses:        137,815  (      4,496 rd   +    133,319 wr)
==3945== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3945== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3945== 
==3945== LL refs:           348,133  (    208,169 rd   +    139,964 wr)
==3945== LL misses:         140,648  (      7,329 rd   +    133,319 wr)
==3945== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita changed the title fix(eof): Use cfg code size limit for eofcreate fix(EOF): Use cfg code size limit for eofcreate Jul 12, 2024
@rakita rakita merged commit 441c105 into main Jul 12, 2024
26 checks passed
@rakita rakita deleted the rakita/cfg_code_size branch July 12, 2024 18:49
This was referenced Jul 12, 2024
This was referenced Jul 15, 2024
j75689 pushed a commit to j75689/revm that referenced this pull request Aug 1, 2024
* fix(eof): Use cfg code size limit for eofcreate

* Update crates/revm/src/context/inner_evm_context.rs

* simplify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants